arm branch + autobalance #116

2023-03-12T03:49:34Z

AG-Coding commented

2023-03-12 03:49:34 +00:00

(Migrated from github.com)

This Pull Request closes issue #

Description of the changes:

I have labelled this issue with the priority and correct subsystem.
I set the person that I worked on this with as a reviewer (who will need to approve the changes)

This Pull Request closes issue # Description of the changes: - - [x] I have labelled this issue with the priority and correct subsystem. - [x] I set the person that I worked on this with as a reviewer (who will need to approve the changes)

FlareTheSaberDragon (Migrated from github.com) reviewed

2023-03-12 06:23:44 +00:00

LinusSkucas (Migrated from github.com) requested changes

2023-03-12 07:18:22 +00:00

src/main/java/frc/robot/Constants.java

Front left is 2, back is 1, front right is 3, back is 5. Pivot is 5, Extender is 6, manipulator is 7/8

src/main/java/frc/robot/RobotContainer.java

					
				@ -93,46 +94,60 @@ public class RobotContainer {

				                  vision.camera.setPipelineIndex(4);

Should be whileTrue

Should be `whileTrue`

whileTrue for the rest of the manipulator commands too, otherwise it never gets cancelled), though we should only be using the PID command in reality

`whileTrue` for the rest of the manipulator commands too, otherwise it never gets cancelled), though we should only be using the PID command in reality

src/main/java/frc/robot/RobotContainer.java

If I'm understanding this correctly, Prelevel does the initial balance and auto level keeps it in balance?
It'd be cool to stick a small comment here about that so others know

If I'm understanding this correctly, Prelevel does the initial balance and auto level keeps it in balance? It'd be cool to stick a small comment here about that so others know

src/main/java/frc/robot/subsystems/ArmSubsystem.java

					
				@ -0,0 +6,4 @@

				import edu.wpi.first.wpilibj2.command.SubsystemBase;

				import frc.robot.Constants;

				/*public class ArmSubsystem extends SubsystemBase {

Why the big comment?

AG-Coding (Migrated from github.com) reviewed

2023-03-12 07:36:21 +00:00

src/main/java/frc/robot/RobotContainer.java

yeah your right

AG-Coding (Migrated from github.com) reviewed

2023-03-12 07:39:25 +00:00

src/main/java/frc/robot/subsystems/ArmSubsystem.java

					
				@ -0,0 +6,4 @@

				import edu.wpi.first.wpilibj2.command.SubsystemBase;

				import frc.robot.Constants;

				/*public class ArmSubsystem extends SubsystemBase {