Practice field 3 12 #117

2023-03-13T03:09:55Z

Iron-Riders-Student commented

2023-03-13 03:09:55 +00:00

(Migrated from github.com)

This Pull Request closes issue #

Description of the changes:

I have labelled this issue with the priority and correct subsystem.
I set the person that I worked on this with as a reviewer (who will need to approve the changes)

This Pull Request closes issue # Description of the changes: - - [ ] I have labelled this issue with the priority and correct subsystem. - [ ] I set the person that I worked on this with as a reviewer (who will need to approve the changes)

LinusSkucas (Migrated from github.com) reviewed

2023-03-13 03:09:55 +00:00

AG-Coding (Migrated from github.com) reviewed

2023-03-13 03:09:55 +00:00

Iron-Riders-Student (Migrated from github.com) reviewed

2023-03-13 03:11:26 +00:00

src/main/java/frc/robot/Constants.java

					
				@ -65,3 +65,3 @@

				          new Translation3d(

				              -Units.inchesToMeters(16), -Units.inchesToMeters(18.68), Units.inchesToMeters(18.5)),

				              -Units.inchesToMeters(33.6), -Units.inchesToMeters(22.25), Units.inchesToMeters(13)),

				          new Rotation3d(0, Math.toRadians(0), Math.toRadians(0)));

Now that we solved the issue of the command not seeming to work (too slow) should we bring strafing for auto balance back?

Iron-Riders-Student (Migrated from github.com) reviewed

2023-03-13 03:12:13 +00:00

src/main/java/frc/robot/RobotContainer.java

					
				@ -39,9 +41,9 @@ public class RobotContainer {

				        new RunCommand(

Should be lowercase

Iron-Riders-Student (Migrated from github.com) reviewed

2023-03-13 03:12:47 +00:00

src/main/java/frc/robot/RobotContainer.java

Again, we should consider bringing back the prelevel command now that auto level works.

AG-Coding (Migrated from github.com) reviewed

2023-03-13 03:40:57 +00:00

src/main/java/frc/robot/Constants.java

					
				@ -65,3 +65,3 @@

				          new Translation3d(

				              -Units.inchesToMeters(16), -Units.inchesToMeters(18.68), Units.inchesToMeters(18.5)),

				              -Units.inchesToMeters(33.6), -Units.inchesToMeters(22.25), Units.inchesToMeters(13)),

				          new Rotation3d(0, Math.toRadians(0), Math.toRadians(0)));

Yeah we could. But idk if we really need it technically need it since we can move on the charging station without slipping. But we can try it

AG-Coding (Migrated from github.com) reviewed

2023-03-13 03:53:02 +00:00

src/main/java/frc/robot/RobotContainer.java

We need it for auto. we could do the same for teleop, we could test it. Not really sure why it didn't work. Although I am not sure if sequential command works the way I think it works. We could just call prelevel command in auto level command directly fi we want to use it