ironriders/ReefScape-PostSeason
Archived
9
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Redo wrist #1

Closed
Amber-leaf wants to merge 0 commits from redo-wrist into main
pull from: redo-wrist
merge into: ironriders:main
Conversation 11 Commits - Files changed - +681 -1009
Amber-leaf commented 2025-09-13 06:00:24 +00:00 (Migrated from github.com)
Copy link

I rewrote most of the wrist and elevator to make them better and wrote an overarching control class for it.

I rewrote most of the wrist and elevator to make them better and wrote an overarching control class for it.
a-mishmash (Migrated from github.com) reviewed 2025-09-13 06:00:24 +00:00
ryanelbert5125gmail (Migrated from github.com) reviewed 2025-09-13 06:00:24 +00:00
Saturncorgi (Migrated from github.com) reviewed 2025-09-13 06:00:24 +00:00
johnluetke commented 2025-09-13 16:38:41 +00:00 (Migrated from github.com)
Copy link

Has this been tested on the robot? I would suggest doing that before merging into main

Has this been tested on the robot? I would suggest doing that before merging into main
Amber-leaf commented 2025-09-14 02:16:20 +00:00 (Migrated from github.com)
Copy link

this is now all in redo-climber

this is now all in [redo-climber](https://github.com/IronRiders/ReefScape-PostSeason/pull/2)
MobileOak (Migrated from github.com) reviewed 2025-09-15 04:08:54 +00:00
src/main/java/org/ironriders/core/ElevatorWirstCTL.java
@ -0,0 +10,4 @@
import edu.wpi.first.wpilibj2.command.Commands;
// This class contains all the state for the moving the elevator and wrist together. You should not call the wrist or elevator commands independently
public class ElevatorWirstCTL extends IronSubsystem {
MobileOak (Migrated from github.com) commented 2025-09-15 04:08:54 +00:00

Wirst -> Wrist

Wirst -> Wrist
MobileOak (Migrated from github.com) reviewed 2025-09-15 04:09:42 +00:00
src/main/java/org/ironriders/core/ElevatorWirstCTL.java
@ -0,0 +29,4 @@
DOWN(0),
L2(7.5), // todo
L3(21), // todo
L4(53); // todo
MobileOak (Migrated from github.com) commented 2025-09-15 04:09:42 +00:00

A todo is good. A todo that lists what needs to be done is much better.

A `todo` is good. A `todo` that lists what needs to be done is much better.
MobileOak (Migrated from github.com) reviewed 2025-09-15 04:12:08 +00:00
src/main/java/org/ironriders/core/ElevatorWirstCTL.java
@ -0,0 +38,4 @@
}
}
public enum WristRotation { // Position in degrees (theoretically)
MobileOak (Migrated from github.com) commented 2025-09-15 04:12:08 +00:00

WristRotationInDegrees is better because you'll see it everywhere and not need a comment.

`WristRotationInDegrees` is better because you'll see it everywhere and not need a comment.
Amber-leaf (Migrated from github.com) reviewed 2025-09-15 14:51:45 +00:00
src/main/java/org/ironriders/core/ElevatorWirstCTL.java
@ -0,0 +10,4 @@
import edu.wpi.first.wpilibj2.command.Commands;
// This class contains all the state for the moving the elevator and wrist together. You should not call the wrist or elevator commands independently
public class ElevatorWirstCTL extends IronSubsystem {
Amber-leaf (Migrated from github.com) commented 2025-09-15 14:51:45 +00:00

fixed

fixed
Amber-leaf (Migrated from github.com) reviewed 2025-09-15 14:52:13 +00:00
src/main/java/org/ironriders/core/ElevatorWirstCTL.java
@ -0,0 +29,4 @@
DOWN(0),
L2(7.5), // todo
L3(21), // todo
L4(53); // todo
Amber-leaf (Migrated from github.com) commented 2025-09-15 14:52:13 +00:00

fixed, now says TODO - These need to be tuned

fixed, now says `TODO - These need to be tuned`
Amber-leaf (Migrated from github.com) reviewed 2025-09-15 14:53:06 +00:00
src/main/java/org/ironriders/core/ElevatorWirstCTL.java
@ -0,0 +38,4 @@
}
}
public enum WristRotation { // Position in degrees (theoretically)
Amber-leaf (Migrated from github.com) commented 2025-09-15 14:53:06 +00:00

i think its pretty obvious, like your never going to be rotating 120 rads or rotations

i think its pretty obvious, like your never going to be rotating 120 rads or rotations
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
a-mishmash
ryanelbert5125gmail
Saturncorgi
Labels
Clear labels   
Minor
This change may affect functionality. eg renaming a variable shouldn't change anything but could

  
Non-Trivial
This code definitely affects functionality

  
Trivial
This change absolutely cannot affect functionality

  
bug
Something isn't working

  
daily
The daily pull request

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

  
bug
Something is not working

  
documentation
Adjustments to internal documentation such as javadoc

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
Minor
Non-Trivial
Trivial
bug
daily
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
bug
documentation
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ironriders/ReefScape-PostSeason!1
No description provided.