PR #48 Autos testing (autos to develop) #48

2024-03-16T00:34:59-05:00

Irishumanoid commented

2024-03-16 00:34:59 -05:00

(Migrated from github.com)

Trello: https://trello.com/c/l6zWx5QX/115-pr-48-autos-testing-autos-to-develop

1withspaghetti (Migrated from github.com) reviewed

2024-03-16 00:34:59 -05:00

1withspaghetti (Migrated from github.com) reviewed

2024-03-20 13:49:37 -05:00

src/main/java/frc/robot/commands/DriveStraight.java

					
				@ -0,0 +1,38 @@

				package frc.robot.commands;

This println should be removed once testing is done.

src/main/java/frc/robot/commands/shooter/ManualAdjust.java

This switch case could be a bit more efficient, such as declaring a desiredAngle variable at the top, then assigning it within the switch case, and afterwards calling m_shooter.setAngle(desiredAngle);

This switch case could be a bit more efficient, such as declaring a `desiredAngle` variable at the top, then assigning it within the switch case, and afterwards calling `m_shooter.setAngle(desiredAngle);`

src/main/java/frc/robot/commands/shooter/PivotMove.java

This debug println should be removed.

src/main/java/frc/robot/commands/shooter/SpinFlywheels.java

Duplicate variable declaration (Although I already commented this on another branch)

src/main/java/frc/robot/subsystems/intake/Intake.java

This is a duplicate of the already existing stop() method

This is a duplicate of the already existing `stop()` method

src/main/java/frc/robot/subsystems/shooter/Shooter.java

Should this be in RobotConstants?

Why are these here, and what are they communicating? Should these static fractions be in RobotConstants and/or used elsewhere in the code?

src/main/java/frc/utils/PathReader.java

Everybody has their repo saved in a different place, and please use the newer java.nio.file.Path API for relative file access, but note this will not work if the code is packaged like a jar.

Everybody has their repo saved in a different place, and please use the newer [java.nio.file.Path](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/nio/file/Path.html) API for relative file access, but note this will not work if the code is packaged like a jar.

There has got to be a better way of doing this, pathplanner already uses Jackson to parse their json and I highly recommend you do that as well.

There has got to be a better way of doing this, pathplanner already uses [Jackson](https://github.com/FasterXML/jackson) to parse their json and I highly recommend you do that as well.

This entire class will never work at runtime, and seems very unneeded.
If the starting pose is required, there seems to be an already existing method in pathplanner that allows you to do this.

This entire class will never work at runtime, and seems very unneeded. If the starting pose is required, there seems to be an [already existing method](https://github.com/mjansen4857/pathplanner/blob/3a7fc679bb48563145dbafd41fdde12fb29bb931/pathplannerlib/src/main/java/com/pathplanner/lib/commands/PathPlannerAuto.java#L54) in pathplanner that allows you to do this.

Irishumanoid (Migrated from github.com) reviewed

2024-03-20 14:09:28 -05:00

src/main/java/frc/robot/commands/shooter/ManualAdjust.java

this was fixed in another branch

Irishumanoid (Migrated from github.com) reviewed

2024-03-20 14:11:55 -05:00

src/main/java/frc/robot/subsystems/shooter/Shooter.java

it is in another branch

Irishumanoid (Migrated from github.com) reviewed

2024-03-20 14:14:20 -05:00

src/main/java/frc/utils/PathReader.java

If only that method was easy to find in the API...

garrettwitowski (Migrated from github.com) reviewed

2024-03-21 11:41:24 -05:00

garrettwitowski (Migrated from github.com) left a comment

No description provided.

We've made good progress on this, but we've still got some work to do.

Irishumanoid (Migrated from github.com) reviewed

2024-03-21 16:23:00 -05:00

src/main/java/frc/robot/subsystems/drive/Drivetrain.java

I'll move back to robot container. It was initially moved to drivetrain to set an initial pose for the auto but that's done internally within path planner.

Irishumanoid (Migrated from github.com) reviewed

2024-03-21 17:23:33 -05:00

src/main/java/frc/robot/subsystems/drive/Drivetrain.java

use swerve drive kinematics to update every time method is called and don't rely on periodic not being overrun

Irishumanoid (Migrated from github.com) reviewed

2024-03-21 17:27:27 -05:00

src/main/java/frc/robot/subsystems/drive/Drivetrain.java

uses local kinematics object now

garrettwitowski (Migrated from github.com) reviewed

2024-03-23 11:59:57 -05:00

src/main/java/frc/robot/subsystems/drive/Drivetrain.java

Hmm why make another kinematics object?

src/main/java/frc/robot/subsystems/drive/Drivetrain.java

I recommend putting this into an array and using that instead with a for loop as it'll be cleaner.

src/main/java/frc/robot/subsystems/drive/Drivetrain.java

Advise renaming this for clarity

This pull request has changes conflicting with the target branch.

src/main/java/frc/robot/RobotContainer.java

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title

PR #48 Autos testing (autos to develop) (#48)

Merge commit body

Reviewed-on: https://git.emeraldcityrobotics.org/chainlynx/2024_Season/pulls/48

PR #48 Autos testing (autos to develop) (#48)

Reviewed-on: https://git.emeraldcityrobotics.org/chainlynx/2024_Season/pulls/48

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin autos:autos

git switch autos

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch develop

git merge --no-ff autos

git switch autos

git rebase develop

git switch develop

git merge --ff-only autos

git switch autos

git rebase develop

git switch develop

git merge --no-ff autos

git switch develop

git merge --squash autos