Offseason UI/Internals Refurbish #8
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
chainlynx/CLAW-ScoutingPWA!8
Loading…
Reference in a new issue
No description provided.
Delete branch "dev"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I am going to start off by apologizing for the 73 changed files and 2.7k additions. I definitely should have broken this up into multiple pull requests, but it is too late now. Thank you so much to those of you who even glimpse at everything and leave helpful feedback 🙏
This PR includes many UI changes, especially loading indicators and error messages, as well as a fundamental change to how extra match data is handled internally. I also documented a large amount of the code and plan to do more in the future. Additionally, the README file now includes instructions and screenshots for how to use/manage the scouting app.
These commits are the result of a lot of feedback and plans I wanted to do before our competitions but never got around to completing. I made these changes to avoid repetitive code and make migration to new games easier once the next season starts. The UI changes also make everything more intuitive and user-friendly, as well as provide extra features such as a pick list for scouting leads.
I want this code to look professional and industry-level, or at least close to that. Mentors, I doubt you hear this often, but I WANT your nit-picky comments, your barrage of questions, etc. I need this code to be easily understandable so future students can work on it effectively.
For the purpose of testing, I attached two zip files representing all the data we collected during our two competitions. You can import them on the data page and play around with the new UI.
You can view an online preview on the website by clicking the link sent by the vercel bot in the comments of this PR.
Scouting Data - 8248 - 2024wasam.zip
Scouting Data - 8248 - 2024wasno.zip
Trello card for these tasks: https://trello.com/c/iDm72GPd/118-scouting-app-refurbish-for-next-season
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Tyler awesome work this app works really well! I was able to get it as a pwa on my iphone while offline. I only had a major problem with the qr code scanner, but I also have some other feedback as well. I think it would be good for you to look over all my comments before we merge your commits. Also sorry for taking 4 months to review your changes.
Never change existing field ids in protobufs. This causes old data to be parsed incorrectly.
I can't get the qr code scanner to work. :(
I found some weird selections issues when tapping on data entries in the data page list.
I can create matches with blank ids which seems unintended based on code in Success and error toasts on data page
it may be cool for crossed out picklist items to go to the bottom automatically.
There's a lot of UI at the bottom of the picklist that should definitely be at the top because the list gets really long
'fully' and other places in the README are not underlined but are in <u> tags (I don't think those work in markdown)
CLAW is an awesome name 😄
All issues should be addressed except for the "weird selection issues" on the data page. I wasn't able to recreate any of these, so I don't know how to resolve them.
Force pushing this because I don't want to force somebody to go through even a fraction of the pain it took for me to write this. Just message me on slack or make an issue if there are any problems you see rn.