ironriders/ChargedUp
Archived
9
Code Issues 23 Pull requests 2 Projects Releases Packages Wiki Activity Actions

Changed subsystems to work with new grabber #142

Open
ryanelbert5125gmail wants to merge 1 commit from EveryBotManipualtorChanges into main
pull from: EveryBotManipualtorChanges
merge into: ironriders:main
Conversation 3 Commits 1 Files changed 4 +93 -98
ryanelbert5125gmail commented 2023-03-29 21:47:23 +00:00 (Migrated from github.com)
Copy link

This Pull Request closes issue #

Description of the changes:

  • Commented Release subsystem because we can just use the cone command to release the box or the box command to release the cone

  • Removed Second Motors in manipulator subsystem because new manipulator only has one motor Commented out old commands that are no longer used

  • Commented Manipulator PID Command because we probably won't use it with the new manipulator

  • Button for Grabbing Cones command(Releasing Boxes command) and Grabbing Boxes command(Releasing Cone command) needs to be set

  • I have labelled this issue with the priority and correct subsystem.

  • I set the person that I worked on this with as a reviewer (who will need to approve the changes)

This Pull Request closes issue # Description of the changes: - Commented Release subsystem because we can just use the cone command to release the box or the box command to release the cone - Removed Second Motors in manipulator subsystem because new manipulator only has one motor Commented out old commands that are no longer used - Commented Manipulator PID Command because we probably won't use it with the new manipulator - Button for Grabbing Cones command(Releasing Boxes command) and Grabbing Boxes command(Releasing Cone command) needs to be set - [ ] I have labelled this issue with the priority and correct subsystem. - [ ] I set the person that I worked on this with as a reviewer (who will need to approve the changes)
AshQuimby (Migrated from github.com) reviewed 2023-03-29 21:47:23 +00:00
ryanelbert5125gmail commented 2023-03-29 21:50:17 +00:00 (Migrated from github.com)
Copy link

DON'T MERGE INTO MAIN YET because we might or might not be using this new manipulator

DON'T MERGE INTO MAIN YET because we might or might not be using this new manipulator
FlareTheSaberDragon (Migrated from github.com) approved these changes 2023-03-29 22:57:34 +00:00
FlareTheSaberDragon (Migrated from github.com) left a comment

noice

noice
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
AshQuimby
FlareTheSaberDragon
Labels
Clear labels   
Arm
Reachy Thingy

  
Auto
i t ' s a l i v e

  
Balancer
"iT'S A BaLaNcInG AcT!"

  
Drivetrain
Vroom Vroom

  
Grabber
☞☞☞☞✌☜☜☜☜

  
Priority: High
Priority Pro Max

  
Priority: Low
Priority

  
Priority: Medium
Priority Pro

  
Scoring
ʎǝuoɯ

  
Vision

   
enhancement
New feature or request

  
feature
Big, new shiny thing

  
help wanted
Extra attention is needed

  
issue
Something ain't not working

  
wontfix
This will not be worked on

  
bug
Something is not working

  
documentation
Adjustments to internal documentation such as javadoc

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
Arm
Auto
Balancer
Drivetrain
Grabber
Priority: High
Priority: Low
Priority: Medium
Scoring
Vision
enhancement
feature
help wanted
issue
wontfix
bug
documentation
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ironriders/ChargedUp!142
No description provided.