ArmSubsystem, ArmPIDCommand, BoxClimberPIDCommand #45

2023-02-01T02:22:48Z

JustinDaniel123 commented

2023-02-01 02:22:48 +00:00

(Migrated from github.com)

Created the ArmSubsystem and added it to RobotContainer. Created the ArmPIDCommand which controls the raising and lowering of the arm. Created the BoxClimberPIDCommand which controls the extending and retracting of the arm.

This Pull Request closes issue #

Description of the changes:

I have labelled this issue with the priority and correct subsystem.
I set the person that I worked on this with as a reviewer (who will need to approve the changes)

Created the ArmSubsystem and added it to RobotContainer. Created the ArmPIDCommand which controls the raising and lowering of the arm. Created the BoxClimberPIDCommand which controls the extending and retracting of the arm. This Pull Request closes issue # Description of the changes: - - [ ] I have labelled this issue with the priority and correct subsystem. - [ ] I set the person that I worked on this with as a reviewer (who will need to approve the changes)

salvobonsma (Migrated from github.com) reviewed

2023-02-01 06:03:23 +00:00

src/main/java/frc/robot/RobotContainer.java

.whenHeld() is deprecated. I think we should be using controller.button(1).onTrue(new ArmPIDCommand(arm, 0) instead.

`.whenHeld()` is deprecated. I think we should be using `controller.button(1).onTrue(new ArmPIDCommand(arm, 0)` instead.

salvobonsma (Migrated from github.com) approved these changes

2023-02-01 06:16:18 +00:00

salvobonsma (Migrated from github.com) left a comment

Code looks to be fine.

salvobonsma (Migrated from github.com) approved these changes

2023-02-01 06:24:21 +00:00

salvobonsma (Migrated from github.com) reviewed

2023-02-01 06:25:10 +00:00

JustinDaniel123 commented

2023-02-08 02:37:05 +00:00

(Migrated from github.com)

Arm subsystem, arm commands, manipulator subsystem pid to stop when it stops, triggers, manipulator pid

LinusSkucas (Migrated from github.com) requested changes

2023-02-08 23:11:57 +00:00

src/main/java/frc/robot/RobotContainer.java

Other manipulator commands

src/main/java/frc/robot/commands/ArmExtendRetractPIDCommand.java

					
				@ -0,0 +1,51 @@

				package frc.robot.commands;

Put PID values in constants file

LinusSkucas (Migrated from github.com) requested changes

2023-02-08 23:40:27 +00:00

src/main/java/frc/robot/commands/ArmExtendRetractPIDCommand.java

					
				@ -0,0 +36,4 @@

				  }

				  @Override

				  public boolean isFinished() {

Have some tolerance for the set point, isFinished should true when it's within tolerance

Have some tolerance for the set point, `isFinished` should true when it's within tolerance

src/main/java/frc/robot/commands/ArmRaiseLowerPIDCommand.java

					
				@ -0,0 +1,51 @@

				package frc.robot.commands;

Use isFinished

Use `isFinished`

src/main/java/frc/robot/commands/ManipulatorPIDCommand.java

					
				@ -0,0 +1,53 @@

				package frc.robot.commands;

Check for speed can go in isFinished

Check for speed can go in `isFinished`

Speed should be in Constants. Speed should not be 0.

LinusSkucas (Migrated from github.com) approved these changes

2023-02-09 00:27:12 +00:00

salvobonsma (Migrated from github.com) approved these changes

2023-02-09 00:30:31 +00:00

Commenting is not possible because the repository is archived.

No reviewers

LinusSkucas

salvobonsma

No labels

No milestone

No project

No assignees

1 participant

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ironriders/ChargedUp!45

				`@ -0,0 +1,51 @@`
				`package frc.robot.commands;`

				`@ -0,0 +1,51 @@`
				`package frc.robot.commands;`

				`@ -0,0 +1,53 @@`
				`package frc.robot.commands;`

Rows
Columns